Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Debugging Documentation of the Spring Boot Maven Plugin #39392

Closed
wants to merge 3 commits into from

Conversation

lukasdo
Copy link
Contributor

@lukasdo lukasdo commented Feb 3, 2024

Replaced the old JVM Argument -Xdebug (which does nothing according to documentation) with newer ones as described in #39388.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 3, 2024
@wanger26
Copy link
Contributor

wanger26 commented Feb 3, 2024

Should we update the test for parseDebugFlags as well as the running-your-application doc to reflect this change?

@lukasdo
Copy link
Contributor Author

lukasdo commented Feb 3, 2024

I added another commit for the running-your-application documentation.

An updated parseDebugsFlags test could look like this:

	void parseDebugFlag() {
		String[] args = parseArgs("-agentlib:jdwp=server=y,transport=dt_socket,address=8000,suspend=n");
		assertThat(args).hasSize(1);
		assertThat(args[0]).isEqualTo("-agentlib:jdwp=server=y,transport=dt_socket,address=8000,suspend=n");
	}

I am not really sure if that would make sense as it would be just testing if one argument is parsed correctly which is also tested in e.g. parseWithExtraSpaces. If desired I could update this test or delete it completely.

@wanger26
Copy link
Contributor

wanger26 commented Feb 3, 2024

Excellent, thank you 💯 It might be worth updating the test to ensure that the parsing works as expected in cases changes are made in the parser in the future.

Copy link
Contributor

@wanger26 wanger26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mhalbritter
Copy link
Contributor

Thank you very much and congratulations on your first contribution 🎉!

@mhalbritter mhalbritter modified the milestones: 3.1.x, 3.1.9 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants