Stop throwing BindingException in tests #39767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adapts the error controller tests that need the request to fail with a bind issue, and simulate the behavior of ModelAttributeMethodProcessor. As of Spring Framework 6.0.x, this processor no longer throws a BindingException, but rather a MethodArgumentNotValidException and the handing of BindException itself is deprecated. This makes sure that those tests can smoothly be executed against Spring Framework 6.2.x as throwing a BindingException now results into an unresolved exception, and an internal server error rather than the expected bad request.
scottfrederick
added
type: task
scottfrederick
pushed a commit
that referenced
this pull request
Feb 27, 2024
This commit adapts the error controller tests that need the request to fail with a bind issue, and simulate the behavior of ModelAttributeMethodProcessor. As of Spring Framework 6.0.x, this processor no longer throws a BindingException, but rather a MethodArgumentNotValidException and the handing of BindException itself is deprecated. This makes sure that those tests can smoothly be executed against Spring Framework 6.2.x as throwing a BindingException now results into an unresolved exception, and an internal server error rather than the expected bad request. See gh-39767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adapts the error controller tests that need the request to fail with a bind issue, and simulate the behavior of
ModelAttributeMethodProcessor.As of Spring Framework 6.0.x, this processor no longer throws a
BindingException, but rather aMethodArgumentNotValidExceptionand the handing ofBindExceptionitself is deprecated.This makes sure that those tests can smoothly be executed against Spring Framework 6.2.x as throwing a
BindingExceptionnow results into an unresolved exception, and an internal server error rather than the expected bad request.