Reduce allocations caused by producible media types

Closes gh-29412
spring-projects · Nov 2, 2022 · 58bb6e7 · 58bb6e7
1 parent e1df056
commit 58bb6e7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/...java/org/springframework/web/reactive/result/method/RequestMappingInfoHandlerMapping.java b/...java/org/springframework/web/reactive/result/method/RequestMappingInfoHandlerMapping.java
@@ -141,9 +141,12 @@ protected void handleMatch(RequestMappingInfo info, HandlerMethod handlerMethod,
 		exchange.getAttributes().put(URI_TEMPLATE_VARIABLES_ATTRIBUTE, uriVariables);
 		exchange.getAttributes().put(MATRIX_VARIABLES_ATTRIBUTE, matrixVariables);
 
-		if (!info.getProducesCondition().getProducibleMediaTypes().isEmpty()) {
-			Set<MediaType> mediaTypes = info.getProducesCondition().getProducibleMediaTypes();
-			exchange.getAttributes().put(PRODUCIBLE_MEDIA_TYPES_ATTRIBUTE, mediaTypes);
+		ProducesRequestCondition producesCondition = info.getProducesCondition();
+		if (!producesCondition.isEmpty()) {
+			Set<MediaType> mediaTypes = producesCondition.getProducibleMediaTypes();
+			if (!mediaTypes.isEmpty()) {
+				exchange.getAttributes().put(PRODUCIBLE_MEDIA_TYPES_ATTRIBUTE, mediaTypes);
+			}
 		}
 	}
 

diff --git a/...ain/java/org/springframework/web/servlet/mvc/method/RequestMappingInfoHandlerMapping.java b/...ain/java/org/springframework/web/servlet/mvc/method/RequestMappingInfoHandlerMapping.java
@@ -147,9 +147,12 @@ protected void handleMatch(RequestMappingInfo info, String lookupPath, HttpServl
 			extractMatchDetails((PatternsRequestCondition) condition, lookupPath, request);
 		}
 
-		if (!info.getProducesCondition().getProducibleMediaTypes().isEmpty()) {
-			Set<MediaType> mediaTypes = info.getProducesCondition().getProducibleMediaTypes();
-			request.setAttribute(PRODUCIBLE_MEDIA_TYPES_ATTRIBUTE, mediaTypes);
+		ProducesRequestCondition producesCondition = info.getProducesCondition();
+		if (!producesCondition.isEmpty()) {
+			Set<MediaType> mediaTypes = producesCondition.getProducibleMediaTypes();
+			if (!mediaTypes.isEmpty()) {
+				request.setAttribute(PRODUCIBLE_MEDIA_TYPES_ATTRIBUTE, mediaTypes);
+			}
 		}
 	}