Skip to content

Commit

Permalink
Deprecate setAllowResultAccessAfterCompletion and document it as broken
Browse files Browse the repository at this point in the history
Closes gh-26557
  • Loading branch information
jhoeller committed Jul 11, 2023
1 parent 1cd994d commit 9e7ee0c
Showing 1 changed file with 6 additions and 4 deletions.
Expand Up @@ -100,13 +100,11 @@
* @author Juergen Hoeller
* @since 4.2
* @see #setSessionFactory
* @see #setDataSource
* @see SessionFactory#getCurrentSession()
* @see DataSourceUtils#getConnection
* @see DataSourceUtils#releaseConnection
* @see org.springframework.jdbc.core.JdbcTemplate
* @see org.springframework.jdbc.support.JdbcTransactionManager
* @see org.springframework.transaction.jta.JtaTransactionManager
* @see org.springframework.orm.jpa.JpaTransactionManager
* @see org.springframework.orm.jpa.vendor.HibernateJpaDialect
*/
@SuppressWarnings("serial")
public class HibernateTransactionManager extends AbstractPlatformTransactionManager
Expand Down Expand Up @@ -271,7 +269,11 @@ public void setPrepareConnection(boolean prepareConnection) {
* @see Connection#setHoldability
* @see ResultSet#HOLD_CURSORS_OVER_COMMIT
* @see #disconnectOnCompletion(Session)
* @deprecated as of 5.3.29 since Hibernate 5.x aggressively closes ResultSets on commit,
* making it impossible to rely on ResultSet holdability. Also, Spring does not provide
* an equivalent setting on {@link org.springframework.orm.jpa.JpaTransactionManager}.
*/
@Deprecated
public void setAllowResultAccessAfterCompletion(boolean allowResultAccessAfterCompletion) {
this.allowResultAccessAfterCompletion = allowResultAccessAfterCompletion;
}
Expand Down

0 comments on commit 9e7ee0c

Please sign in to comment.