-
Notifications
You must be signed in to change notification settings - Fork 37.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Polish "Allow AbstractUrlHandlerMapping to add/remote handlers"
See gh-32064
- Loading branch information
Showing
2 changed files
with
254 additions
and
107 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
143 changes: 143 additions & 0 deletions
143
...src/test/java/org/springframework/web/servlet/handler/AbstractUrlHandlerMappingTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,143 @@ | ||
| /* | ||
| * Copyright 2002-2024 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.web.servlet.handler; | ||
|
|
||
| import java.util.Map; | ||
| import java.util.function.Consumer; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import org.springframework.context.support.StaticApplicationContext; | ||
| import org.springframework.lang.Nullable; | ||
|
|
||
| import static java.util.Map.entry; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.assertj.core.api.Assertions.assertThatNoException; | ||
|
|
||
| /** | ||
| * Tests for {@link AbstractUrlHandlerMapping}. | ||
| * | ||
| * @author Stephane Nicoll | ||
| */ | ||
| class AbstractUrlHandlerMappingTests { | ||
|
|
||
| private final AbstractUrlHandlerMapping mapping = new AbstractUrlHandlerMapping() {}; | ||
|
|
||
| @Test | ||
| void registerRootHandler() { | ||
| TestController rootHandler = new TestController(); | ||
| mapping.registerHandler("/", rootHandler); | ||
| assertThat(mapping).satisfies(hasMappings(rootHandler, null, Map.of())); | ||
| } | ||
|
|
||
| @Test | ||
| void registerDefaultHandler() { | ||
| TestController defaultHandler = new TestController(); | ||
| mapping.registerHandler("/*", defaultHandler); | ||
| assertThat(mapping).satisfies(hasMappings(null, defaultHandler, Map.of())); | ||
| } | ||
|
|
||
| @Test | ||
| void registerSpecificMapping() { | ||
| TestController testHandler = new TestController(); | ||
| mapping.registerHandler("/test", testHandler); | ||
| assertThat(mapping).satisfies(hasMappings(null, null, Map.of("/test", testHandler))); | ||
| } | ||
|
|
||
| @Test | ||
| void registerSpecificMappingWithBeanName() { | ||
| StaticApplicationContext context = new StaticApplicationContext(); | ||
| context.registerSingleton("controller", TestController.class); | ||
| mapping.setApplicationContext(context); | ||
| mapping.registerHandler("/test", "controller"); | ||
| assertThat(mapping.getHandlerMap().get("/test")).isSameAs(context.getBean("controller")); | ||
| } | ||
|
|
||
| @Test | ||
| void unregisterRootHandler() { | ||
| TestController rootHandler = new TestController(); | ||
| TestController defaultHandler = new TestController(); | ||
| TestController specificHandler = new TestController(); | ||
| mapping.registerHandler("/", rootHandler); | ||
| mapping.registerHandler("/*", defaultHandler); | ||
| mapping.registerHandler("/test", specificHandler); | ||
| assertThat(mapping).satisfies(hasMappings(rootHandler, defaultHandler, Map.of("/test", specificHandler))); | ||
|
|
||
| mapping.unregisterHandler("/"); | ||
| assertThat(mapping).satisfies(hasMappings(null, defaultHandler, Map.of("/test", specificHandler))); | ||
| } | ||
|
|
||
| @Test | ||
| void unregisterDefaultHandler() { | ||
| TestController rootHandler = new TestController(); | ||
| TestController defaultHandler = new TestController(); | ||
| TestController specificHandler = new TestController(); | ||
| mapping.registerHandler("/", rootHandler); | ||
| mapping.registerHandler("/*", defaultHandler); | ||
| mapping.registerHandler("/test", specificHandler); | ||
| assertThat(mapping).satisfies(hasMappings(rootHandler, defaultHandler, Map.of("/test", specificHandler))); | ||
|
|
||
| mapping.unregisterHandler("/*"); | ||
| assertThat(mapping).satisfies(hasMappings(rootHandler, null, Map.of("/test", specificHandler))); | ||
| } | ||
|
|
||
| @Test | ||
| void unregisterSpecificHandler() { | ||
| TestController rootHandler = new TestController(); | ||
| TestController defaultHandler = new TestController(); | ||
| TestController specificHandler = new TestController(); | ||
| mapping.registerHandler("/", rootHandler); | ||
| mapping.registerHandler("/*", defaultHandler); | ||
| mapping.registerHandler("/test", specificHandler); | ||
| assertThat(mapping).satisfies(hasMappings(rootHandler, defaultHandler, Map.of("/test", specificHandler))); | ||
|
|
||
| mapping.unregisterHandler("/test"); | ||
| assertThat(mapping).satisfies(hasMappings(rootHandler, defaultHandler, Map.of())); | ||
| } | ||
|
|
||
| @Test | ||
| void unregisterUnsetRootHandler() { | ||
| assertThatNoException().isThrownBy(() -> mapping.unregisterHandler("/")); | ||
| } | ||
|
|
||
| @Test | ||
| void unregisterUnsetDefaultHandler() { | ||
| assertThatNoException().isThrownBy(() -> mapping.unregisterHandler("/*")); | ||
| } | ||
|
|
||
| @Test | ||
| void unregisterUnknownHandler() { | ||
| TestController specificHandler = new TestController(); | ||
| mapping.registerHandler("/test", specificHandler); | ||
|
|
||
| mapping.unregisterHandler("/test/*"); | ||
| assertThat(mapping.getHandlerMap()).containsExactly(entry("/test", specificHandler)); | ||
| } | ||
|
|
||
|
|
||
| private Consumer<AbstractUrlHandlerMapping> hasMappings(@Nullable Object rootHandler, | ||
| @Nullable Object defaultHandler, Map<String, Object> handlerMap) { | ||
| return actual -> { | ||
| assertThat(actual.getRootHandler()).isEqualTo(rootHandler); | ||
| assertThat(actual.getDefaultHandler()).isEqualTo(defaultHandler); | ||
| assertThat(actual.getHandlerMap()).containsExactlyEntriesOf(handlerMap); | ||
| }; | ||
| } | ||
|
|
||
| private static class TestController {} | ||
|
|
||
| } |