RestTemplate adds duplicate accept header information #22320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
bclozel
changed the title
bclozel
added
type: backport
bclozel
pushed a commit
that referenced
this pull request
Feb 11, 2019
Prior to this commit, the various `HttpMessageConverter` instances configured for a given `RestTemplate` instance could all contribute `MediaType` values to the "Accept:" request header. This could lead to duplicate media types in that request header, cluttering for the HTTP request for no reason. This commit ensures that only distinct values are added to the request. Issue: SPR-16690 Closes gh-22320 Closes gh-21231
|
Fixed via 3e1b3c3 |
jhoeller
added
the
in: web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :)
In 4.3.x version, I found a bug that caused the
Acceptheader to be duplicated.I have added a validation test and fixed the bug, if you could review this PR then I appreciate it.
It seems to have been fixed in 5.0.x and above. It appears to be occurring in versions below 4.3.x.
If this PR is not in the correct format, please let me know. I will fix it.
Thank you.