Fix and improve Javadoc in spring-core and spring-context #28802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
type: documentation
sbrannen
reviewed
Jul 13, 2022
| @@ -131,7 +131,7 @@ public AnnotationVisitor visitAnnotation(final String name, final String descrip | |||
| /** | |||
| * Visits an array value of the annotation. Note that arrays of primitive values (such as byte, | |||
| * boolean, short, char, int, long, float or double) can be passed as value to {@link #visit | |||
| * visit}. This is what {@link ClassReader} does for non empty arrays of primitive values. | |||
| * visit}. This is what {@link ClassReader} does for non-empty arrays of primitive values. | |||
There was a problem hiding this comment.
Please refrain from modifying classes under org.springframework.asm, org.springframework.cglib, and org.springframework.objenesis. Those include repackaged forks of the third-party libraries ASM, CGLIB, and Objenesis. Any refactoring to those classes should take place upstream in the originating repository. The Spring Framework will then pick up the changes when syncing with official updates of the forked third-party libraries.
The above is our standard policy, but don't worry about updating this PR. I'll revert all ASM and CGLIB changes while merging.
sbrannen
pushed a commit
to sbrannen/spring-framework
that referenced
this pull request
Jul 13, 2022
|
This has been merged. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.