Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown tasks annotated with @Scheduled when waitForTasksToCompleteOnShutdown is true #29155

Closed
wants to merge 1 commit into from

Conversation

savinov
Copy link

@savinov savinov commented Sep 14, 2022

Shutdown tasks annotated with @scheduled when waitForTasksToCompleteOnShutdown is true

  1. ScheduledTaskRegistrar: shutdown taskScheduler of ExecutorConfigurationSupport type in destroy()
  2. ScheduledAnnotationBeanPostProcessor: do not cancel tasks in destroy(), taskRegistrar cancel them

Closes gh-26482

…nShutdown is true

1. ScheduledTaskRegistrar: shutdown taskScheduler of ExecutorConfigurationSupport type in destroy()
2. ScheduledAnnotationBeanPostProcessor: do not cancel tasks in destroy(), taskRegistrar cancel them

Closes spring-projectsgh-26482
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 14, 2022
@rstoyanchev rstoyanchev added the in: core Issues in core modules (aop, beans, core, context, expression) label Jan 24, 2023
@jhoeller jhoeller added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 20, 2023
@jhoeller
Copy link
Contributor

This is effectively superseded by #31019 and the wider lifecycle revision in 6.1 in general.

@jhoeller jhoeller closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

waitForTasksToCompleteOnShutdown has no effect on tasks created with @Scheduled annotation
4 participants