Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use computeIfAbsent() in ConcurrentMapCacheManager.getCache() #29680

Closed
wants to merge 1 commit into from
Closed

Use computeIfAbsent() in ConcurrentMapCacheManager.getCache() #29680

wants to merge 1 commit into from

Conversation

drnow4u
Copy link

@drnow4u drnow4u commented Dec 12, 2022 •
edited

#25997 Replace explicit synchronized and implicit synchronized in ConcurrentHashMap::put with modern functional api.

@pivotal-cla
Copy link

@MarcinNowak-codes Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@MarcinNowak-codes Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 12, 2022
@drnow4u drnow4u marked this pull request as draft December 12, 2022 21:22
@drnow4u drnow4u marked this pull request as ready for review December 12, 2022 21:25
@drnow4u drnow4u changed the title #25997 ConcurrentMap functional api ConcurrentMap functional api Dec 12, 2022
@sbrannen sbrannen changed the title ConcurrentMap functional api Use computeIfAbsent() in ConcurrentMapCacheManager.getCache() Dec 16, 2022
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Dec 16, 2022
@snicoll
Copy link
Member

snicoll commented Aug 27, 2023

Thanks for the PR but @jhoeller addressed this already in the meantime, see #30780. Sorry for the wasted effort.

@snicoll snicoll closed this Aug 27, 2023
@snicoll snicoll added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 27, 2023
@sbrannen sbrannen removed the request for review from jhoeller August 27, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@drnow4u @pivotal-cla @snicoll @sbrannen @spring-projects-issues