NoUniqueBeanDefinitionException should make sure beansNameFound is serializable #29753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@perlun Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@perlun Thank you for signing the Contributor License Agreement! |
perlun
force-pushed
the
fix/use-serializable-set-in-exception
branch
from
d580f3f
to
5cd200b
Compare
|
(Test failure seems unrelated to me. 馃) |
rstoyanchev
added
the
in: core
snicoll
changed the title
snicoll
added
type: bug
snicoll
pushed a commit
that referenced
this pull request
Aug 27, 2023
snicoll
added a commit
that referenced
this pull request
Aug 27, 2023
|
Thanks again @perlun and that's a good catch. Rather than doing this at the caller level, I've fixed the exception itself so that it creates a copy of the collection. This is similar to what we do for arrays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen in Spring 5.3.18.
LinkedHashMap.keySet()tends to return ajava.util.LinkedHashMap$LinkedKeySetinstance, which is not serializable. This becomes a problem then when you e.g. try to propagate theNoUniqueBeanDefinitionExceptionerror across a network boundary (our use case).Wrapping these in
HashSets seem like the simplest way around. The only other call site was passing in anArrays.asList()object, andasListis explicitly defined to return a serializable list.(If this change is considered good/safe, it would perhaps be worth back-porting this to the Spring 5 branch as well. It does indeed change the semantics, but it could also arguably be considered a back-port safe bug fix.)
Thanks for a great project! 馃檹