Increase number of TOC levels in generated PDF documentation #29781
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
type: documentation
sbrannen
removed
the
status: waiting-for-triage
sbrannen
changed the title
sbrannen
reviewed
Jan 24, 2023
There was a problem hiding this comment.
Thanks for submitting the PR.
As I explained in my comments, to achieve the goal of increasing the number of TOC levels in the PDF we would prefer to modify the spring-framework.adocbook directly.
In light of that, I have updated the title of this PR and will make the necessary changes.
| @@ -1,4 +1,4 @@ | |||
| :toc: left | |||
| :toclevels: 4 | |||
| :toclevels: 5 | |||
There was a problem hiding this comment.
We explicitly selected 4 TOC levels and do not wish to change that to 5.
| @@ -1,6 +1,7 @@ | |||
| :noheader: | |||
| :toc: | |||
| include::attributes.adoc[] | |||
| include::page-layout.adoc[] | |||
There was a problem hiding this comment.
page-layout.adoc is specific to the HTML5 backend and as such should not be applied for the generated PDF.
For the PDF, we explicitly apply document configuration local to the spring-framework.adocbook file -- as can be seen by the existing :noheader: and :toc: entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced by 4b22a4a.
This is single pdf file now.
This is splitted file before.
