Skip to content

Fix R2dbcTransactionManager debug log: don't log a Mono #29800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2023
Merged

Fix R2dbcTransactionManager debug log: don't log a Mono #29800

merged 1 commit into from
Jan 16, 2023
+1 −1

Conversation

mscheong01
Copy link
Contributor

Motivation:
There's an issue when logging the current connection inside R2dbcTransactionManager#doBegin :
the mono object is logged instead of the connection lambda parameter, resulting in wrong log
ex)
2023-01-11 15:09:32.809 DEBUG 45809 --- [actor-tcp-nio-2] o.s.r.c.R2dbcTransactionManager : Acquired Connection [MonoRetry] for R2DBC transaction

@pivotal-cla
Copy link

@j-min5u Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@j-min5u Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 11, 2023
@simonbasle simonbasle added in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 11, 2023
@simonbasle simonbasle added this to the 6.0.4 milestone Jan 11, 2023
simonbasle
simonbasle approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution @j-min5u !

@simonbasle simonbasle changed the title fix wrong log string in R2dbcTransactionManager Fix R2dbcTransactionManager debug log: don't log a Mono Jan 11, 2023
@simonbasle
Copy link
Contributor

mmh looks like there's an issue with the backport bot. considering that, and the fact the 6.0.4 and 5.3.25 releases are planned for today, I won't rush things and instead reassign this to 6.0.5 and defer merging.

@simonbasle simonbasle self-assigned this Jan 11, 2023
@simonbasle simonbasle modified the milestones: 6.0.4, 6.0.5 Jan 11, 2023
@simonbasle
Copy link
Contributor

simonbasle commented Jan 11, 2023 •
edited
Loading

TODO

  • add the for: backport-to-5.3.x and perform the backport once 6.0.4 is out the door

Sorry, something went wrong.

@simonbasle simonbasle mentioned this pull request Jan 16, 2023
Closed
@simonbasle simonbasle added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x labels Jan 16, 2023
@simonbasle simonbasle merged commit c0e38a2 into spring-projects:main Jan 16, 2023
simonbasle pushed a commit that referenced this pull request Jan 16, 2023
@mscheong01 @simonbasle
Fix R2dbcTransactionManager debug log: don't log a Mono (#29800)
4bd2531 
When logging the current connection inside R2dbcTransactionManager
doBegin, the mono object was logged instead of the connection lambda
parameter.

Other similar debug-level logs do use the actual Connection object,
so this commit does the same.

Backport of gh-29800
Closes gh-29824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbasle simonbasle

Assignees

@simonbasle simonbasle

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mscheong01 @pivotal-cla @simonbasle @spring-projects-issues