Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always fall back to original method if annotation pointcut used #30534

Merged
merged 1 commit into from Nov 23, 2023
Merged

Always fall back to original method if annotation pointcut used #30534

merged 1 commit into from Nov 23, 2023

Conversation

quaff
Copy link
Contributor

@quaff quaff commented May 24, 2023 •
edited by sbrannen

Prior to this commit, AspectJExpressionPointcut didn't fall back to the original method if !@annotation() is used, which can result in a false positive.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 24, 2023
@quaff quaff marked this pull request as draft May 24, 2023 01:56
@quaff quaff changed the title Improve AspectJExpressionPointcut to use proper method for matching Always fall back to original method if annotation pointcut used May 24, 2023
@quaff quaff marked this pull request as ready for review May 24, 2023 04:43
@quaff
Always fall back to original method if annotation pointcut used
ef73ba9 
Prior to this commit, AspectJExpressionPointcut doesn't fall back to original method if `!@annotation()` is used, it can cause false positive result.

Fix spring-projectsGH-27119
@quaff
Copy link
Contributor Author

quaff commented May 26, 2023

Would you take a look? @sbrannen @jhoeller

@sbrannen sbrannen added type: bug A general bug in: core Issues in core modules (aop, beans, core, context, expression) labels Jul 15, 2023
@sbrannen
Copy link
Member

Yes, we'll take a look.

Thanks for the PR.

@jhoeller jhoeller mentioned this pull request Nov 23, 2023
Closed
@jhoeller jhoeller self-assigned this Nov 23, 2023
@jhoeller jhoeller removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 23, 2023
@jhoeller jhoeller added this to the 6.1.2 milestone Nov 23, 2023
@jhoeller jhoeller merged commit 3a6d0c1 into spring-projects:main Nov 23, 2023
5 checks passed
jhoeller added a commit that referenced this pull request Nov 23, 2023
@jhoeller
Apply fallback for proxy with negative match or annotation pointcut
0d8dee2 
See gh-30534
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Projects
None yet
Milestone
6.1.2
Development

Successfully merging this pull request may close these issues.

Not annotation pointcut matches dynamic proxy methods incorrectly
4 participants
@quaff @sbrannen @jhoeller @spring-projects-issues