Remove non-empty filename check in ContentDisposition builder
#30537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ContentDisposition Builder must be consistent with ContentDisposition and accept nullable filename
|
@Foolkin Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@Foolkin Thank you for signing the Contributor License Agreement! |
sbrannen
changed the title
ContentDisposition builder
sbrannen
added
in: web
sbrannen
changed the title
ContentDisposition builderContentDisposition builder
sbrannen
removed
the
status: waiting-for-triage
|
Hi @Foolkin, Congratulations on submitting your first PR to the Spring Framework! 👍 This has been merged into Thanks |
mdeinum
pushed a commit
to mdeinum/spring-framework
that referenced
this pull request
Jun 29, 2023
This commit ensures that the ContentDisposition.Builder is consistent with ContentDisposition and accepts null/empty filenames. Closes spring-projectsgh-30537
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ContentDisposition Builder must be consistent with ContentDisposition and accept a nullable filename.