Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example in Javadoc for MultipartBodyBuilder #30593

Closed
wants to merge 1 commit into from
Closed

Fix example in Javadoc for MultipartBodyBuilder #30593

wants to merge 1 commit into from

Conversation

heoYH
Copy link
Contributor

@heoYH heoYH commented Jun 5, 2023

The example of MultipartBodyBuilder was wrong, so it was corrected.

@heoYH
Update MultipartBodyBuilder
0d9ff3b 
Update MultipartBodyBuilder example document
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 5, 2023
@sbrannen
Copy link
Member

sbrannen commented Jul 7, 2023

Hi @heoYH,

Good catch, and congratulations on submitting your first PR for the Spring Framework! 👍

Although .body(BodyInserters.fromMultipartData(multipartBody)) would work, I assume the intention was to use .bodyValue(multipartBody) instead.

So I'll merge this PR to give you credit and then change the example to use the more succinct bodyValue() method.

@sbrannen sbrannen added the type: documentation A documentation task label Jul 7, 2023
@sbrannen sbrannen self-assigned this Jul 7, 2023
@sbrannen sbrannen added this to the 6.0.11 milestone Jul 7, 2023
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 7, 2023
@sbrannen sbrannen changed the title Fix comment example of MultipartBodyBuilder. Fix example in Javadoc for MultipartBodyBuilder Jul 7, 2023
sbrannen pushed a commit that referenced this pull request Jul 7, 2023
@heoYH @sbrannen
Fix example in Javadoc for MultipartBodyBuilder
7ff80bc 
See gh-30593
@sbrannen sbrannen closed this in 8bf79cc Jul 7, 2023
@sbrannen
Copy link
Member

sbrannen commented Jul 7, 2023 •
edited

This has been merged into 6.0.x and main.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Projects
None yet
Milestone
6.0.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heoYH @sbrannen @spring-projects-issues