Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Reminder Information to websocket doc #30599

Closed
wants to merge 1 commit into from
Closed

Adding Reminder Information to websocket doc #30599

wants to merge 1 commit into from

Conversation

heartape
Copy link

@heartape heartape commented Jun 6, 2023

I didn't use SockJS when I first started using Stomp, but the entire document used this option, which caused me to be unable to connect to the browser. Later, when I discovered this option, I was able to restore it to normal. I think it is necessary to provide a reminder to prevent spending time investigating such worthless issues.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 6, 2023
@sdeleuze sdeleuze self-assigned this Aug 27, 2023
@sdeleuze sdeleuze added type: documentation A documentation task in: web Issues in web modules (web, webmvc, webflux, websocket) labels Aug 27, 2023
@sdeleuze
Copy link
Contributor

I understand how the documentation was potentially confusing related to the default usage of SockJS, but this has been revised via #30857 so I think the reminder is not needed anymore.

@sdeleuze sdeleuze closed this Aug 28, 2023
@sdeleuze sdeleuze added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants