Introduce ObservationThreadLocalTestExecutionListener in the TestContext framework
#30651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this change we have no option to pass the ObservationRegistry that is registered in the given TestContext's ApplicationContext as the one that should be used by the ObservationThreadLocalAccessor. with this change we create a TestExecutionListener that will set an ObservationRegistry registered in the TestContext's ApplicationContext for each test class and after each test class will restore the previously stored ObservationRegistry instance
|
cc @rstoyanchev after upgrading the context propagation library I needed to update one class |
spring-projects-issues
added
the
status: waiting-for-triage
jonatan-ivanov
approved these changes
Jun 12, 2023
rstoyanchev
requested changes
Jun 13, 2023
...src/main/java/org/springframework/web/servlet/mvc/method/annotation/ReactiveTypeHandler.java
Outdated
Show resolved
Hide resolved
sbrannen
changed the title
ObservationThreadLocalTestExecutionListener in the TestContext framework
sbrannen
added
in: test
sbrannen
requested changes
Jun 13, 2023
...in/java/org/springframework/test/context/observation/ObservationThreadLocalTestListener.java
Outdated
Show resolved
Hide resolved
...in/java/org/springframework/test/context/observation/ObservationThreadLocalTestListener.java
Outdated
Show resolved
Hide resolved
| * This implementation is not thread-safe. | ||
| * | ||
| * @author Marcin Grzejszczak | ||
| * @since 6.0 |
There was a problem hiding this comment.
Suggested change
| * @since 6.0 | |
| * @since 6.1 |
I imagine this would be added in 6.1.
There was a problem hiding this comment.
We've made the whole train of changes in Micrometer Core (1.10.8), Context Propagation (1.0.3), Micrometer Tracing (1.0.7) and Reactor all in patch versions to fix bugs related to context propagation with reactor. We need this to be working in a patch release IMO. Without this change context propagation will not work properly. I would say that adding this component is a bug fix not an enhancement.
...in/java/org/springframework/test/context/observation/ObservationThreadLocalTestListener.java
Outdated
Show resolved
Hide resolved
...in/java/org/springframework/test/context/observation/ObservationThreadLocalTestListener.java
Outdated
Show resolved
Hide resolved
...in/java/org/springframework/test/context/observation/ObservationThreadLocalTestListener.java
Outdated
Show resolved
Hide resolved
spring-test/src/main/java/org/springframework/test/context/observation/package-info.java
Outdated
Show resolved
Hide resolved
...va/org/springframework/test/context/observation/ObservationThreadLocalTestListenerTests.java
Outdated
Show resolved
Hide resolved
...in/java/org/springframework/test/context/observation/ObservationThreadLocalTestListener.java
Outdated
Show resolved
Hide resolved
sbrannen
added
status: waiting-for-feedback
…ervation/ObservationThreadLocalTestListener.java Co-authored-by: Sam Brannen <sam@sambrannen.com>
…ervation/ObservationThreadLocalTestListener.java Co-authored-by: Sam Brannen <sam@sambrannen.com>
…ervation/ObservationThreadLocalTestListener.java Co-authored-by: Sam Brannen <sam@sambrannen.com>
…ervation/package-info.java Co-authored-by: Sam Brannen <sam@sambrannen.com>
…ervation/ObservationThreadLocalTestListenerTests.java Co-authored-by: Sam Brannen <sam@sambrannen.com>
- dependencies ordered alphabetically - renamed the test execution listener to contain "execution" and "micrometer" in the name - production code lines are smaller (up to 100 chars) - test execution attribute is a private static final field - added javadocs in the test execution listener
sbrannen
added
status: superseded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change we have no way to pass the
ObservationRegistrythat is registered in the given test'sApplicationContextas the one that should be used by theObservationThreadLocalAccessor.With this change we introduce a
TestExecutionListenerthat will set anObservationRegistryregistered in the test'sApplicationContextfor each test class and after each test class will restore the previously storedObservationRegistryinstance.