New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce TestExecutionListener
for Micrometer's ObservationRegistry
in the TestContext framework
#30658
Introduce TestExecutionListener
for Micrometer's ObservationRegistry
in the TestContext framework
#30658
Commits on Jun 12, 2023
-
Added ObservationThreadLocalTestListener
without this change we have no option to pass the ObservationRegistry that is registered in the given TestContext's ApplicationContext as the one that should be used by the ObservationThreadLocalAccessor. with this change we create a TestExecutionListener that will set an ObservationRegistry registered in the TestContext's ApplicationContext for each test class and after each test class will restore the previously stored ObservationRegistry instance
Configuration menu - View commit details
-
Copy full SHA for 5a9d85e - Browse repository at this point
Copy the full SHA 5a9d85eView commit details
Commits on Jun 13, 2023
-
Update spring-test/src/main/java/org/springframework/test/context/obs…
…ervation/ObservationThreadLocalTestListener.java Co-authored-by: Sam Brannen <sam@sambrannen.com>
Configuration menu - View commit details
-
Copy full SHA for 1c95b1c - Browse repository at this point
Copy the full SHA 1c95b1cView commit details -
Update spring-test/src/main/java/org/springframework/test/context/obs…
…ervation/ObservationThreadLocalTestListener.java Co-authored-by: Sam Brannen <sam@sambrannen.com>
Configuration menu - View commit details
-
Copy full SHA for dd9b3f8 - Browse repository at this point
Copy the full SHA dd9b3f8View commit details -
Update spring-test/src/main/java/org/springframework/test/context/obs…
…ervation/ObservationThreadLocalTestListener.java Co-authored-by: Sam Brannen <sam@sambrannen.com>
Configuration menu - View commit details
-
Copy full SHA for 724b4bf - Browse repository at this point
Copy the full SHA 724b4bfView commit details -
Update spring-test/src/main/java/org/springframework/test/context/obs…
…ervation/package-info.java Co-authored-by: Sam Brannen <sam@sambrannen.com>
Configuration menu - View commit details
-
Copy full SHA for 3ad61ed - Browse repository at this point
Copy the full SHA 3ad61edView commit details -
Update spring-test/src/test/java/org/springframework/test/context/obs…
…ervation/ObservationThreadLocalTestListenerTests.java Co-authored-by: Sam Brannen <sam@sambrannen.com>
Configuration menu - View commit details
-
Copy full SHA for 2237def - Browse repository at this point
Copy the full SHA 2237defView commit details -
Applied changes following the review
- dependencies ordered alphabetically - renamed the test execution listener to contain "execution" and "micrometer" in the name - production code lines are smaller (up to 100 chars) - test execution attribute is a private static final field - added javadocs in the test execution listener
Configuration menu - View commit details
-
Copy full SHA for 74ffe99 - Browse repository at this point
Copy the full SHA 74ffe99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f23db0 - Browse repository at this point
Copy the full SHA 2f23db0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13cf317 - Browse repository at this point
Copy the full SHA 13cf317View commit details -
Configuration menu - View commit details
-
Copy full SHA for e77a986 - Browse repository at this point
Copy the full SHA e77a986View commit details