Change Kotlin Any to be a nullable type in AOP refdoc examples
#31015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using "Any" calls to void methods will fail, with a cryptic error message.
spring-projects-issues
added
the
status: waiting-for-triage
sdeleuze
added
type: documentation
sdeleuze
changed the title
Any to be a nullable type in AOP refdoc examples
sdeleuze
pushed a commit
to sdeleuze/spring-framework
that referenced
this pull request
Aug 10, 2023
This commit changes Any to Any? in ProceedingJoinPoint Kotlin examples in order to be consistent with Java and avoid a "NullPointerException: pjp.proceed() must not be null" error. See spring-projectsgh-31015
|
Merged with additional similar changes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using "Any" as return type, as suggested by the documentation example, in a
@Around-Aspect calls to void methods withpjp.proceed()will fail, with a cryptic NullPointerException error:java.lang.NullPointerException: pjp.proceed() must not be nullI have made an example project to showcase this behavior:
spring-aop-docs-bug