Link to spring.factories used in the TestContext framework in the reference manual
#31723
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
in: test
| can contribute their own `TestExecutionListener` implementations to the list of default | ||
| listeners in the same manner through their own `META-INF/spring.factories` properties | ||
| file. | ||
| [its `META-INF/spring.factories` properties file](https://github.com/spring-projects/spring-framework/blob/main/spring-test/src/main/resources/META-INF/spring.factories). |
There was a problem hiding this comment.
This has a spring-framework-code attribute that should be used rather than the hardcoded link. See antora.yml.
There was a problem hiding this comment.
Thanks for your feedback @snicoll, makes sense. 👍 Nice to learn about some of the Asciidoc features, seems like a nice usage of it in this case.
I adjusted both this and incorporated the suggestion from @sbrannen, please re-check. (Sam - it did perhaps not make as much sense in the https://docs.spring.io/spring-framework/reference/testing/testcontext-framework/ctx-management/context-customizers.html#testcontext-context-customizers-automatic-discovery case, since it referred to both "Spring Framework and Spring Boot", but the link only refers to the Spring Framework one.. but, possibly still a step in the right direction. 🤔)
There was a problem hiding this comment.
Yes, indeed. That's a step in the right direction. I'll rework the wording locally after merging the PR.
sbrannen
changed the title
spring.factories for default TestExecutionListener config in the reference manual
There was a problem hiding this comment.
Hi @perlun,
In addition to the spring-framework-code change that @snicoll requested, would you be willing to make a similar change to the section on ContextCustomizerFactory configuration?
If not, we can handle that ourselves.
In any case, please let us know so that we can proceed with this PR.
sbrannen
added
the
status: waiting-for-feedback
sbrannen
removed
the
status: waiting-for-feedback
sbrannen
changed the title
spring.factories for default TestExecutionListener config in the reference manualspring.factories for the TestContext framework in the reference manual
sbrannen
changed the title
spring.factories for the TestContext framework in the reference manualspring.factories used in the TestContext framework in the reference manual
This type of change would be useful (since it makes it easier for the reader to find this file), but... will it be hard to support with different versions of the docs? Given that it should technically refer to the "same version" of the file (replacing
mainin the URL with the tag in question), to be really great.