Add MySQLIdentityColumnMaxValueIncrementer
#31784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `DataFieldMaxValueIncrementer` can be used with identity columns in MySQL 8.0 or later.
spring-projects-issues
added
the
status: waiting-for-triage
jhoeller
added
in: data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds
MySQLIdentityColumnMaxValueIncrementerto resolve #18989.Using a MySQL auto-increment column as a sequence with
AbstractIdentityColumnMaxValueIncrementerwas not practical before MySQL 8 as the auto-increment counter was only stored in memory but not persisted. With MySQL 8.0 and InnoDB, this behavior has changed: https://dev.mysql.com/doc/refman/8.0/en/innodb-auto-increment-handling.html#innodb-auto-increment-initializationWith MySQL 8 and InnoDB, the new incrementer can be used safely in a setup with active-active replication. If the database parameters
auto_increment_incrementandauto_increment_offsetare configured appropriately, the incrementer will not produce duplicate ids even if different database instances are queried.I've assembled a toy setup with a multi-threaded test against two MySQL instances with active-active replication here: https://github.com/hpoettker/mysql-incrementer-demo