Fix Comparators.nullsLow and Comporators.nullsHigh behavior #31808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort null values lower than non-null values, nullsHigh should sort null values higher than non-null values
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
type: regression
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullsLowshould s…ort null values lower than non-null values,nullsHighshould sort null values higher than non-null valuesThe reverse behavior has been introduced in Spring Framework 6.1.X, it was correct before.
See https://github.com/spring-projects/spring-framework/blob/main/spring-core/src/test/java/org/springframework/util/comparator/NullSafeComparatorTests.java which tests the same comparators used before.