Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify use of regexp Path Pattern in javadoc #31886

Closed

Conversation

FBibonne
Copy link
Contributor

As far I saw how the framework process web requests Mapping and as far I read the code of CaptureVariablePathElement, when using a path pattern with a regexp (like {spring:[a-z]+}) in a @RequestMapping, the regexp can match only one path segment of the path of the request. So this PR proposes to improve the javadoc of PathPattern to specify that the regexp match can only happen in one path segment.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 22, 2023
@bclozel bclozel added type: documentation A documentation task in: web Issues in web modules (web, webmvc, webflux, websocket) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 5, 2024
@bclozel bclozel self-assigned this Jan 5, 2024
@bclozel bclozel added this to the 6.1.3 milestone Jan 5, 2024
@bclozel bclozel closed this in a108e70 Jan 5, 2024
@bclozel
Copy link
Member

bclozel commented Jan 5, 2024

Thanks @FBibonne for your contribution!

@FBibonne FBibonne deleted the specify-regexp-pathpattern-use branch January 10, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants