Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of WebClientAdapter in reference documentation #31917

Conversation

0x1306e6d
Copy link
Contributor

WebClientAdapter#forClient(WebClient) is deprecated. Use WebClientAdapter#create(WebClient) instead and fix typo.

@pivotal-cla
Copy link

@ghkim3221 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@ghkim3221 Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 28, 2023
@0x1306e6d 0x1306e6d changed the title Update WebClient docs about RestClient interface Update RestClient docs about creating interface using WebClient Dec 28, 2023
@0x1306e6d 0x1306e6d force-pushed the restclient-interface-webclient-docs branch from 7902f44 to ddb5276 Compare December 28, 2023 12:15
@0x1306e6d 0x1306e6d changed the title Update RestClient docs about creating interface using WebClient Update RestClient docs about creating interface using WebClient Dec 28, 2023
@0x1306e6d 0x1306e6d force-pushed the restclient-interface-webclient-docs branch from ddb5276 to ec1977d Compare December 28, 2023 12:16
@snicoll snicoll added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 28, 2023
@snicoll snicoll self-assigned this Dec 28, 2023
@snicoll snicoll added this to the 6.1.3 milestone Dec 28, 2023
@snicoll snicoll changed the title Update RestClient docs about creating interface using WebClient Fix usage of WebClientAdapter in reference documentation Dec 28, 2023
@snicoll snicoll closed this in 28e5468 Dec 28, 2023
@snicoll
Copy link
Member

snicoll commented Dec 28, 2023

Good catch @ghkim3221 and thank you for making your first contribution to Spring Framework. There was an extra usage in the same file so I've fixed that as well, see b1c0b65.

@0x1306e6d
Copy link
Contributor Author

Thank you !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants