Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document exception handling for HTTP Interface client with RestClient and RestTemplate #31991

Conversation

OlgaMaciaszek
Copy link
Contributor

Fixes gh-31782.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 9, 2024
@rstoyanchev rstoyanchev self-assigned this Jan 9, 2024
@rstoyanchev rstoyanchev added type: documentation A documentation task in: web Issues in web modules (web, webmvc, webflux, websocket) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 9, 2024
@rstoyanchev rstoyanchev added this to the 6.1.3 milestone Jan 9, 2024
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.

Could we structure this more like a bullet list as it is in the beginning of the HTTP Interface client section, and also follow the same order? In other words:

For RestClient:

name exception raised by default for 4xx and 5xx...

... source code snippet...

reference to Javadoc for more details

For WebClient:

... same ...

For RestTemplate:

... same ...

I think that would make it more readable and easier to focus on the relevant part.

@OlgaMaciaszek OlgaMaciaszek force-pushed the add-more-exception-handling-docs branch from 25703ec to 060f49e Compare January 10, 2024 11:08
@rstoyanchev rstoyanchev changed the title Document exception handling for RestClient and RestTemplate-backed interface clients Document exception handling for HTTP Interface client with RestClient and RestTemplate Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide RestClient example in HTTP Interface Exception Handling section of reference docs
3 participants