Exclude URI query from remaining WebClient checkpoints #31992
Closed
+55
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
@aaronrosser Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@aaronrosser Thank you for signing the Contributor License Agreement! |
aaronrosser
changed the title
aaronrosser
force-pushed
the
exclude-url-query-from-checkpoint-and-exception
branch
from
811832b to
e6fe130
Compare
aaronrosser
commented
Jan 10, 2024
| (request != null ? " from " + request.getMethod() + " " + getUriToLog(request.getURI()) : ""); | ||
| } | ||
|
|
||
| private static URI getUriToLog(URI uri) { |
There was a problem hiding this comment.
Maybe this method should go in WebClientUtils? 🤔
rstoyanchev
added
the
in: web
rstoyanchev
added
type: enhancement
rstoyanchev
changed the title
rstoyanchev
pushed a commit
that referenced
this pull request
Jan 10, 2024
|
Thanks for the pull request. I added a method to |
rstoyanchev
added
status: backported
rstoyanchev
added a commit
that referenced
this pull request
Jan 10, 2024
That was quick. Thank you 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects: latest (v6.1.2)
Module: spring-webflux
Continuing from this issue #29148 and its fix f9d8367 regarding full request URIs including sensitive query parameters being included in mono checkpoints.
This PR sanitises URIs included in
DefaultWebClient.DefaultRequestBodyUriSpec::exchangeWebClientResponseExceptions created viaWebClientResponseException::create