New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MockHttpServletRequest.java #32718
Open
cnabro
wants to merge
2
commits into
spring-projects:main
Choose a base branch
from
cnabro:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In MockHttpServletRequest 'application/json; Modified so that the 'charset=utf-8' format is no longer used.
Change variable order
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Apr 27, 2024
jhoeller
added
in: test
Issues in the test module
in: web
Issues in web modules (web, webmvc, webflux, websocket)
labels
Apr 29, 2024
@cnabro it's not clear how you get the problem. Using this: mockMvc.perform(post("/courses")
.contentType(MediaType.APPLICATION_JSON)
.content("{\"title\":\"Test Course\"}") results in:
|
snicoll
added
the
status: waiting-for-feedback
We need additional information before we can continue
label
May 2, 2024
@rstoyanchev Test Code@ExtendWith(SpringExtension.class)
@WebMvcTest(CourseController.class)
public class CourseControllerTest {
@Autowired
private MockMvc mockMvc;
@Test
public void testCreateCourse() throws Exception {
Course course = new Course();
course.setId(1L);
course.setTitle("Test Course");
given(courseService.saveCourse(any(Course.class))).willReturn(course);
mockMvc.perform(post("/courses")
.contentType(MediaType.APPLICATION_JSON)
.content("{\"title\":\"Test Course\"}"))
.andExpect(status().isOk())
.andExpect(jsonPath("$.id").value(1L))
.andExpect(jsonPath("$.title").value("Test Course"));
}
} Stacktrace
|
spring-projects-issues
added
status: feedback-provided
Feedback has been provided
and removed
status: waiting-for-feedback
We need additional information before we can continue
labels
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: test
Issues in the test module
in: web
Issues in web modules (web, webmvc, webflux, websocket)
status: feedback-provided
Feedback has been provided
status: waiting-for-triage
An issue we've not yet triaged or decided on
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
application/json; charset=utf-8
is no longer supported, but MockHttpServletRequest still uses charset by default, so the mockMVC test fails.Sample Test