Align StandaloneMockMvcBuilder with trailing slash defaults #32796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evan-mc Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@evan-mc Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
in: test
sbrannen
changed the title
StandaloneMockMvcBuilder
|
@rstoyanchev, what do you think about switching the default here? |
sbrannen
added
the
status: waiting-for-internal-feedback
|
Yes, it makes sense to align the default, but maybe in 6.2 only. |
rstoyanchev
removed
status: waiting-for-triage
bclozel
changed the title
StandaloneMockMvcBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring no longer supports trailing slashes by default, as of #28552. However, unit tests that are setup using the
StandaloneMockMvcBuilderstill have default support for trailing slashes. This causes an inconsistency that does not reflect what spring does by default. By changing the default to false, unit tests will accurately reflect the base implementation, which will cause less confusion when unit tests are working and production code is not.