Fix ClassCastException from return value validation with proxy when adaptConstraintViolations=true #33105
+81
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix argument in call to applyReturnValueValidation() method in MethodValidationInterceptor.java. Method argument was passed instead of the return value of the method that was being validated. Closes spring-projectsgh-33092
|
@imvtsl Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@imvtsl Thank you for signing the Contributor License Agreement! |
|
@rstoyanchev |
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
requested changes
Jun 27, 2024
rstoyanchev
changed the title
rstoyanchev
added
type: bug
sbluemel
added a commit
to sbluemel/spring-framework
that referenced
this pull request
Jun 27, 2024
Fix argument in call to applyReturnValueValidation() method in MethodValidationInterceptor.java. Method argument was passed instead of the return value of the method that was being validated. Closes spring-projects spring-projectsgh-33105
|
Sure. I am working on adding test now. |
Fix argument in call to applyReturnValueValidation() method in MethodValidationInterceptor.java. Method argument was passed instead of the return value of the method that was being validated. Closes spring-projectsgh-33092
|
@rstoyanchev I read CONTRIBUTING.md and I have a query. Should I sqaush these 2 commits into one or is it okay? |
rstoyanchev
pushed a commit
that referenced
this pull request
Jun 28, 2024
Fix argument in call to applyReturnValueValidation() method in MethodValidationInterceptor.java. Method argument was passed instead of the return value of the method that was being validated. See gh-33105
|
I've squashed them for you and updated the tests a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix argument in call to applyReturnValueValidation() method in MethodValidationInterceptor.java. Method argument was passed instead of the return value of the method that was being validated.
Closes gh-33092