Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2226: Add RetryTopicConfigurationSupport #2227

Closed
wants to merge 11 commits into from
Closed

GH-2226: Add RetryTopicConfigurationSupport #2227

wants to merge 11 commits into from

Commits on Apr 15, 2022

  1. spring-projectsGH-2226: Add RetryTopicConfigurationSupport 

    Resolves spring-projects#2226

Add RetryTopicConfigurationSupport
Add @EnableRetryTopic
Add KafkaBackOffManagerConfigurationSupport
    @tomazfernandes
    tomazfernandes committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    3da9ea9 View commit details
    Browse the repository at this point in the history

  2. Address code review comments 

    * Change deprecated constants for strings
* Remove deprecation suppressions
* Remove ApplicationContext and BeanFactory from constructors
* Change TaskExecutor shutdown logic to DisposableBean
    @tomazfernandes
    tomazfernandes committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    06979ef View commit details
    Browse the repository at this point in the history

  3. Remove KafkaBackOffManagerConfigurationSupport

    @tomazfernandes
    tomazfernandes committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    f10f276 View commit details
    Browse the repository at this point in the history

  4. Move Task Executor logic to Timing Adjuster

    @tomazfernandes
    tomazfernandes committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    58bfaea View commit details
    Browse the repository at this point in the history

  5. Add unit tests

    @tomazfernandes
    tomazfernandes committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    c82fa57 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2022

  1. Enable managing fatal exceptions with a List 

    Create defaultFatalExceptionsList method in `ExceptionClassifier`

Change RetryTopicConfigurationSupport logic to provide a list instead of a configurer for non-blocking retries
    @tomazfernandes
    tomazfernandes committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    39d6549 View commit details
    Browse the repository at this point in the history

  2. Make provided TaskExecutor a bean 

    Add KafkaBackOffManagerConfigurer to RetryTopicConfigurationSupport
    @tomazfernandes
    tomazfernandes committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    a887fba View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Add documentation 

    Review javadocs

Few other adjustments
    @tomazfernandes
    tomazfernandes committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    d0f7265 View commit details
    Browse the repository at this point in the history

  2. Use JavaUtils instead of if statements 

    Add acceptIfInstanceOf to JavaUtils
    @tomazfernandes
    tomazfernandes committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    38a58a9 View commit details
    Browse the repository at this point in the history

  3. Address PR review comments

    @tomazfernandes
    tomazfernandes committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    c43f159 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Restore ThreadPoolTaskExecutor bean

    @tomazfernandes
    tomazfernandes committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    dd512b4 View commit details
    Browse the repository at this point in the history