Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods from CookieServerCsrfTokenRepository #14139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

milaneuh
Copy link

From : #14132

Removing the Deprecated methods used in CookieServerCsrfTokenRepository.

@pivotal-cla
Copy link

@milaneuh Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@milaneuh Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 14, 2023
@marcusdacoregio marcusdacoregio self-assigned this Nov 14, 2023
@marcusdacoregio marcusdacoregio added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement type: breaks-passivity A change that breaks passivity with the previous release and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 14, 2023
@marcusdacoregio marcusdacoregio added this to the 7.0.0-M1 milestone Nov 14, 2023
@marcusdacoregio
Copy link
Contributor

Hi, @milaneuh. Thanks for the PR.

Since this is only scheduled for 7.0, getting this merged will take a while. I think one feedback is that we also have to add documentation to help users migrate, and that documentation would be added to the Preparing to 7.0 section.

@milaneuh
Copy link
Author

Hi, @milaneuh. Thanks for the PR.

Since this is only scheduled for 7.0, getting this merged will take a while. I think one feedback is that we also have to add documentation to help users migrate, and that documentation would be added to the Preparing to 7.0 section.

Hi, can I help in any way for the documentation ?

@marcusdacoregio
Copy link
Contributor

Yes, you can add a new Web section under Preparing for 7.0 similar to the Configuration section. There you should guide users to avoid using the deprecated methods and, instead, use the customizer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: breaks-passivity A change that breaks passivity with the previous release type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants