New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh 7750 implement jdbcuserpassworddetailsmanager #14148
base: main
Are you sure you want to change the base?
Gh 7750 implement jdbcuserpassworddetailsmanager #14148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your thorough approach, @geirhe! You are right that it's a large PR. We'll just take it one step at a time. Some of my inline feedback hopefully makes the changeset smaller.
I saw your questions in the PR description. Hopefully they are mostly answered by my inline feedback. The only one I don't think I answered yet was about Sql
vs Query
. Let's please call the setter methods Query
to align with the DSL.
config/src/main/java/org/springframework/security/config/SecurityNamespaceHandler.java
Outdated
Show resolved
Hide resolved
config/src/main/java/org/springframework/security/config/SecurityNamespaceHandler.java
Outdated
Show resolved
Hide resolved
...amework/security/config/annotation/authentication/builders/AuthenticationManagerBuilder.java
Outdated
Show resolved
Hide resolved
...amework/security/config/annotation/authentication/builders/AuthenticationManagerBuilder.java
Outdated
Show resolved
Hide resolved
...tation/authentication/configurers/provisioning/JdbcUserPasswordDetailsManagerConfigurer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/springframework/security/provisioning/JdbcUserDetailsManager.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/security/provisioning/JdbcUserPasswordDetailsManager.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/springframework/security/provisioning/JdbcUserDetailsManagerTests.java
Outdated
Show resolved
Hide resolved
...test/java/org/springframework/security/provisioning/JdbcUserPasswordDetailsManagerTests.java
Outdated
Show resolved
Hide resolved
...amework/security/config/annotation/authentication/builders/AuthenticationManagerBuilder.java
Outdated
Show resolved
Hide resolved
f3fdd19
to
7a405c4
Compare
d943d7a
to
02222cc
Compare
.../src/main/java/org/springframework/security/provisioning/JdbcUserPasswordDetailsManager.java
Outdated
Show resolved
Hide resolved
...test/java/org/springframework/security/provisioning/JdbcUserPasswordDetailsManagerTests.java
Show resolved
Hide resolved
I think I have handled all your comments now, and updated the docs. I have two remaining tasks outside of this pr noted:
I'll rebase and mark the review as ready now. This caused some formatting issues that spread into files I have not touched otherwise. I decided to include the changes here in order to get the build to pass. |
…olding off on supporting specification of password update queries
…o allow overriding SQL query
…e password query for the new manager
…perties named *Sql to *Query, update documentation
…from documentation
a8c5a75
to
113d6ac
Compare
@jzheaux Not much is happening here, and I suppose that is either because you have decided to not apply this PR, because the PR got lost in the stack, or because you are horribly busy. I am assuming the middle situation with a side order of the latter since that is what I can relate to the most, so I am subtly poking your inbox. Please don't take this as nagging. |
Related to gh-7550.
This is an implementation of a UserDetailsManager that will keep passwords updated.
@jzheaux I have tried to add support for configuring this stuff both in code and xml. I have decided to stop because I would like some feedback before I dig the hole deeper:
I think this PR is getting bigger than I would like, so if I could get feedback on the direction I'll probably lob the documentation changes into a separate one.
It is probably easier to follow the PR by looking at a commit at a time. Sorry about that.