Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 7750 implement jdbcuserpassworddetailsmanager #14148

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

geirhe
Copy link
Contributor

@geirhe geirhe commented Nov 15, 2023

Related to gh-7550.

This is an implementation of a UserDetailsManager that will keep passwords updated.

@jzheaux I have tried to add support for configuring this stuff both in code and xml. I have decided to stop because I would like some feedback before I dig the hole deeper:

  • do you prefer the query properties to be called Sql or Query? The code seems to be in two minds about this, so I temporarily added both. I found it hard to achieve consistent naming.
  • have I missed any bits that integrates with JdbcUserDetailsManager? I don't know the code base all that well yet. Guidance will be appreciated.
  • Where can I found the documentation site code? There is some SQL there I need to tweak.
  • How do you approach migration instructions? I didn't find any documentation for how to do that.
  • HttpSecurityConfiguration.jdbcAuthenticationWithPasswordManagement is mis-named. Should match the XML config, I guess. I'll sort it.
  • I don't know how you version XSD schemas. I need some new bits. Was I correct in just making a new version?
  • Does my code follow your coding guidelines? There are usually a bucketful of ceremonies, and where I live these are all automated. I don't know if my assumptions are correct here. Trying to do right, but I am aware that I am writing code for an unknown team culture.

I think this PR is getting bigger than I would like, so if I could get feedback on the direction I'll probably lob the documentation changes into a separate one.

It is probably easier to follow the PR by looking at a commit at a time. Sorry about that.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 15, 2023
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your thorough approach, @geirhe! You are right that it's a large PR. We'll just take it one step at a time. Some of my inline feedback hopefully makes the changeset smaller.

I saw your questions in the PR description. Hopefully they are mostly answered by my inline feedback. The only one I don't think I answered yet was about Sql vs Query. Let's please call the setter methods Query to align with the DSL.

@geirhe
Copy link
Contributor Author

geirhe commented Dec 14, 2023

Thanks for your thorough approach, @geirhe! You are right that it's a large PR. We'll just take it one step at a time. Some of my inline feedback hopefully makes the changeset smaller.

Thank you @jzheaux .

It has been very busy at work, but I'll try to deal with this PR the next weeks.

@geirhe geirhe force-pushed the gh-7750-implement-jdbcuserpassworddetailsmanager branch from f3fdd19 to 7a405c4 Compare December 14, 2023 19:32
@geirhe geirhe force-pushed the gh-7750-implement-jdbcuserpassworddetailsmanager branch from d943d7a to 02222cc Compare December 28, 2023 13:12
@geirhe geirhe requested a review from jzheaux January 16, 2024 17:32
@geirhe
Copy link
Contributor Author

geirhe commented Jan 20, 2024

I think I have handled all your comments now, and updated the docs.

I have two remaining tasks outside of this pr noted:

  • update the jdbc example to ansi sql. Is it important that the username and password fields are case insensitive?
  • add postgres example schema to the documentation (basically using a text data type instead of varchar. data types are the same)

I'll rebase and mark the review as ready now. This caused some formatting issues that spread into files I have not touched otherwise. I decided to include the changes here in order to get the build to pass.

@geirhe geirhe marked this pull request as ready for review January 20, 2024 09:32
@geirhe geirhe force-pushed the gh-7750-implement-jdbcuserpassworddetailsmanager branch from a8c5a75 to 113d6ac Compare January 20, 2024 09:42
@geirhe geirhe marked this pull request as draft January 20, 2024 09:47
@geirhe geirhe marked this pull request as ready for review January 21, 2024 09:06
@geirhe
Copy link
Contributor Author

geirhe commented Feb 18, 2024

@jzheaux Not much is happening here, and I suppose that is either because you have decided to not apply this PR, because the PR got lost in the stack, or because you are horribly busy. I am assuming the middle situation with a side order of the latter since that is what I can relate to the most, so I am subtly poking your inbox. Please don't take this as nagging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants