Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupedOpenApi.builder addOpenApiCustomiser execution order is reversed #1633

Closed
FelixStumvoll opened this issue Apr 26, 2022 · 1 comment
Closed

Comments

@FelixStumvoll
Copy link

Since 1.6.8 when using GroupedOpenApi.builder().addOpenApiCustomiser() multiple times, the customizers are executed in reverse compared to the previous version.
E.g. if i add customizer A and then customizer B i expect that A is executed first. However in 1.6.8 the order is reversed and B is called first.

I'm not sure if this is intended behavior or was introduced on accident.

@bnasslahsen
Copy link
Contributor

@FelixStumvoll,

It was correctly introduced, to handle other cases ...
Maybe, we should preserve this order and accept that OpenApiCustomiser list will not be final.

I have made a change that could help handling other cases; without impacting the one you are mentionning.
Let me know if the last SNAPSHOT fixes the issue for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants