fix: Support PageableDefault#value() #1700
Merged
+140
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PageableDefault#value is an alias for @PageableDefault#size, but currently,
springdoc-openapi
is only reading the default size fromsize
, notvalue
.This change attempts to get the default size from
size
first. If it is the default value, then it will get the default size fromvalue
. I'm not sure if this is the correct precedence, anyone knows if Java annotation parsers normally give higher precedence tovalue
or the aliased parameter?