Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RouterOperationCustomizer #1706

Merged

Conversation

hyeonisism
Copy link

Summary
The RouterOperationCustomizer customizes the RouterOperation before the path is created so that it is reflected in the document.

Result
As a result, we can change the properties of router operation to give the user a point to customize the document before creating a path.

@junoyoon
Copy link

junoyoon commented Jun 14, 2022

@bnasslahsen

This PR is to prevent overwriting multiple router operations having same path.
RouterOperationCustomizer is introduced for developers to customize routerOperation object properties such as Path.

See below to how to define the RouterOperationCustomizer.
(This impl differentiates the each path by add params into path string if params exist)

https://github.com/springdoc/springdoc-openapi/pull/1706/files#diff-12f0ec82aa8f79cddb6f1649257873491e8c2daab92ba30d35b1b430954dacb3R19-R257

Please review this if you don't mind.

Add new line at end of files

Update to receive routerOperation as a return
@hyeonisism hyeonisism force-pushed the add-router-operation-customizer branch from 44669c0 to a1a9b96 Compare June 15, 2022 05:21
@junoyoon
Copy link

@bnasslahsen could you share your valueable time for review and comment for this, please?

@bnasslahsen
Copy link
Contributor

@hyeonisism,

I will add it to my next todo list.

@junoyoon
Copy link

@bnasslahsen any progress?

@bnasslahsen bnasslahsen merged commit d0710e6 into springdoc:master Aug 2, 2022
@bnasslahsen
Copy link
Contributor

@bnasslahsen any progress?

merged!

bnasslahsen added a commit that referenced this pull request Aug 2, 2022
bnasslahsen added a commit that referenced this pull request Aug 2, 2022
@junoyoon
Copy link

junoyoon commented Aug 3, 2022

Thx @bnasslahsen

@uc4w6c uc4w6c mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants