Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Java record for v1.6 #1830

Closed
uc4w6c opened this issue Sep 4, 2022 · 1 comment · Fixed by #1835
Closed

Support Java record for v1.6 #1830

uc4w6c opened this issue Sep 4, 2022 · 1 comment · Fixed by #1835

Comments

@uc4w6c
Copy link
Collaborator

uc4w6c commented Sep 4, 2022 •
edited
Loading

Record was supported for v2 in this issue (#1728), but I want to use record for v1.6 as well.

v1.6 is build with Java8, reflection is required to support it, but if that's okay with you, I'm writing the code, so can I raise a pull request?
@uc4w6c uc4w6c changed the title Support Java record for v1.6.XX Support Java record for v1.6 Sep 4, 2022
@bnasslahsen
Copy link
Collaborator

@uc4w6c,

That is ok to propose a PR.
Just make sure you dont break apps running in java 8 versions.

uc4w6c added a commit to uc4w6c/springdoc-openapi that referenced this issue Sep 6, 2022
@uc4w6c
Support Java record for v1.6. Fixes springdoc#1830
c0274ea
@uc4w6c uc4w6c mentioned this issue Sep 6, 2022
Merged
uc4w6c added a commit to uc4w6c/springdoc-openapi that referenced this issue Sep 6, 2022
@uc4w6c
Support Java record for v1.6. Fixes springdoc#1830
e1f75de
bnasslahsen added a commit that referenced this issue Sep 19, 2022
@bnasslahsen
Merge pull request #1835 from uc4w6c/support-java-record-for-v1_6

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
3bd5ba0 
Support Java record for v1.6. Fixes #1830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Java record for v1.6. Fixes #1830 uc4w6c/springdoc-openapi
2 participants
@bnasslahsen @uc4w6c