Sort request methods #1878
Merged
Sort request methods #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Output example of the bug (running the test I added twice without TreeSet): |
|
Hey @bnasslahsen, I saw you are active here, can you take a look at my PR when you got the time? |
|
Thank you for your contribution to the project1 |
bnasslahsen
added a commit
that referenced
this pull request
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug with a random integer suffix for generated operation id when there is
@RequestMappingwithout a specific method.Similar to another issue that was solved already: #96
But the solution introduced for the closed issue didn't help in this case.
Added a test to show it is solved. You can reproduce the issue by reverting from TreeSet to HashSet and running the test multiple times (you will see you get different operation IDs randomly).
The reason is, HashSet does not guarantee the same order, so in different runs, it may produce different orders and therefor different operation ids.
It is my first open-source contribution so please let me know if I missed anything in the process.