Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: incorrect generic param for multi interfaces #1684

Merged
merged 2 commits into from Jul 30, 2022
Merged

bug: incorrect generic param for multi interfaces #1684

merged 2 commits into from Jul 30, 2022

Commits on May 31, 2022

  1. bug: incorrect generic param for multi interfaces

    public interface CrudControllerBase<S extends Service<?, ?>,  SRC extends CustomQuery> {
        // some code
    }
    
    public interface ExistsControllerBase<S extends Service<?, ?>, EQUERY extends CustomQuery> {
    
    @PostMapping("exist")
    default Response<Boolean> exist(@requestbody PostBody<EQUERY> req) {
        // some code
    }
    
    }
    
    @RestController
    @RequestMapping("/v1/{tenant_id:[0-9A-Z]+}/user")
    public class UserAdminController implements 
        CrudControllerBase<AdminUserService, AdminUserSearch>,
        ExistsControllerBase<AdminUserService, UserExistsQuery> {
        // some code
    }
    
    the "requestBody" in "/v1/{tenant_id}/user/exist" path get incorrect schema: 
        "schema": {
             "$ref": "#/components/schemas/PostBodyCustomQuery"
          }
    the correct schema should be:
        "schema": {
             "$ref": "#/components/schemas/PostBodyUserExistsQuery"
          }
    dino-proj committed May 31, 2022
    Configuration menu
    Copy the full SHA
    08c849b View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Configuration menu
    Copy the full SHA
    040df71 View commit details
    Browse the repository at this point in the history