Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump normalize version from v5 to v8 #760

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Conversation

aliuk2012
Copy link
Contributor

Reduces file size (uncompressed) from 8KB to 6KB.
The main difference really is dropping all the lte IE 9 support hacks.
(https://github.com/necolas/normalize.css/blob/master/CHANGELOG.md)

v5 was released way back in 2016 and v8 was released way back in 2018.
The repo doesn't seem be maintained and questions asked by the community
seem to support that assumption (necolas/normalize.css#880)

Theres a bigger question of whether this is the approach we still want to
use or perhaps investigate whether there is a modern normalizer out there some
where. In the issue I linked to there are a couple of suggestions at alternative
ones that we could look at.

Copy link
Contributor

@morgaan morgaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aliuk2012 thank you for raising this concern.

As you have some legit question around this, maybe this Bump is a bit premature and would benefit chating in a frontend-open-space about the more modern options that exist out there for that purpose.

I wonder, as well, if there are some custom builds that would dump any IE hacks... to save some bytes over the wire, but maybe it is so negligible that it is not worth the effort.

Hence, I see a lot of removal, is it because the modern/evergreen browsers adopted those styles in their default stylesheets in the end?

@aliuk2012
Copy link
Contributor Author

Outcome from the last open space team chat was that we would merge this as a temp solution and then look at rolling our own but agreed that would involve more work and could be done later.

Reduces file size (uncompressed) from 8KB to 6KB.
The main difference really is dropping all the lte IE 9 support hacks.
(https://github.com/necolas/normalize.css/blob/master/CHANGELOG.md)

v5 was released way back in 2016 and v8 was released way back in 2018.
The repo doesn't seem be maintained and questions asked by the community
seem to support that assumption (necolas/normalize.css#880)

Theres a bigger question of whether this is the approach we still want to
use or perhaps investigate whether there is a modern normalizer out there some
where. In the issue I linked to there are a couple of suggestions at alternative
ones that we could look at.
Copy link
Contributor

@sturobson sturobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a tentative that folks upgrading to this version of toolkits should check to see if there's anything in this version that (completely) breaks the content (not the layout).

@aliuk2012 aliuk2012 merged commit b11632c into master Jul 4, 2022
@aliuk2012 aliuk2012 deleted the bump-normalize-version branch July 4, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants