Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Guava dependency #2412

Merged
merged 26 commits into from
Jun 30, 2018
Merged

Removing Guava dependency #2412

merged 26 commits into from
Jun 30, 2018

Conversation

neil1hart
Copy link

@neil1hart neil1hart commented May 11, 2018

This PR upgrades the library to Java 8 and removes the Guava dependency.
(Fix issue #1082)
It is similar to PR #2086

The main reason is remove the transitive guava dependency for anything dependent on this library.

Incompatiblilites:
Updates from 1.7 to 1.8 as the minimum Java version. Rebase pulled in master's java change.
Public API changes where guava constructs have been exposed
Support for Guava Optional in API may have been lost.

What is missing:
I tried to limit the changed lines so there are many areas that can be cleaned up or refactored

  • Cleanups (Predicates, Function can be written more compact with java 8)
  • Duplicate code, like the replacement for Strings.nullToEmpty()

@neil1hart neil1hart changed the title Noguava Removing Guava dependency May 11, 2018
@codecov
Copy link

codecov bot commented May 11, 2018

Codecov Report

Merging #2412 into master will decrease coverage by 0.09%.
The diff coverage is 94.76%.

@@             Coverage Diff             @@
##             master    #2412     +/-   ##
===========================================
- Coverage     95.08%   94.98%   -0.1%     
- Complexity     2989     3018     +29     
===========================================
  Files           339      339             
  Lines          7949     7956      +7     
  Branches        643      637      -6     
===========================================
- Hits           7558     7557      -1     
- Misses          251      253      +2     
- Partials        140      146      +6

@springfox springfox deleted a comment May 12, 2018
@springfox springfox deleted a comment May 12, 2018
@springfox springfox deleted a comment May 12, 2018
@springfox springfox deleted a comment May 12, 2018
@springfox springfox deleted a comment May 12, 2018
@springfox springfox deleted a comment May 12, 2018
@springfox springfox deleted a comment May 12, 2018
@springfox springfox deleted a comment May 12, 2018
@springfox springfox deleted a comment May 12, 2018
@springfox springfox deleted a comment May 12, 2018
@springfox springfox deleted a comment May 12, 2018
@springfox springfox deleted a comment May 12, 2018
@springfox springfox deleted a comment May 12, 2018
@springfox springfox deleted a comment May 14, 2018
@springfox springfox deleted a comment May 14, 2018
@springfox springfox deleted a comment May 14, 2018
@springfox springfox deleted a comment May 14, 2018
@neil1hart
Copy link
Author

I missed some needed changes that I commented out. Will get it updated by tonight.

@neil1hart
Copy link
Author

org.reflections is breaking java 8 guava also. I'm looking at that also

@dilipkrish
Copy link
Member

@neil1hart there is a PR for replacing reflections.

@dilipkrish
Copy link
Member

BTW ❤️ the detailed incremental commits! Thank you for being taking the extra effort to make reviewing PRs easy!

@neil1hart
Copy link
Author

Should I continue to look at increasing the coverage or is the slight decrease OK? I can't quite figure out where to add except maybe adding a test for guava Optional in a controller but need the Reflection replacement PR. I replaced the the guava Optional in BugsController with java.
I'll continue to rebase.

@neil1hart neil1hart closed this Jun 9, 2018
@neil1hart neil1hart reopened this Jun 9, 2018
@dilipkrish
Copy link
Member

@neil1hart don't think we need to chase down to that level, at some point it reaches diminishing returns. Im going to try and pull your change in, in the coming week or so. However, you may need to resolve conflicts from ongoing work in master.

@dilipkrish dilipkrish added this to the 3.0 milestone Jun 30, 2018
@dilipkrish dilipkrish merged commit f65e743 into springfox:master Jun 30, 2018
@dilipkrish
Copy link
Member

@neil1hart thank you very much for a very detailed and thorough PR. It made pulling it in so much easier!

@neil1hart neil1hart deleted the noguava branch July 5, 2018 15:50
@ArchangelX360
Copy link

@dilipkrish Hey, do we have a rough estimation when this will be published?

@dilipkrish
Copy link
Member

Around september... mostly waiting on OAS 3.0 and #2056

@ArchangelX360
Copy link

Oh alright, do your best :). Thanks

@sourabhsparkala
Copy link

Hello All, I was wondering when are you planning for a release with this change? Please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants