Bug/2511 #2513
Merged
Bug/2511 #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Spring 4. Using annotation utils instead of newer annotation attribute calls.
Codecov Report
@@ Coverage Diff @@
## master #2513 +/- ##
============================================
+ Coverage 95.08% 95.11% +0.03%
- Complexity 2989 2997 +8
============================================
Files 339 340 +1
Lines 7949 7962 +13
Branches 643 643
============================================
+ Hits 7558 7573 +15
+ Misses 251 250 -1
+ Partials 140 139 -1 |
|
@dbaje thanks for the pr!! |
…ved it to the core so it could be available in other parts of the code. Also introduced a customer SpringVersion class return our own, made it a normal class so we can mock it for our tests. This should increase test coverage.
|
Made some changes and used the spring capabilities utility. I needed to move it so it would be available for the rest of the code. Also made some changes to be compatible with mocking and version checking in tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do/fix?
Bug #2511
Are there unit tests? If not how should this be manually tested?
No tests as this is to slove backwards compatibility
Any background context you want to provide?
Attribute "name" and "required" in PathVariable annotation were added in Spring 4.3.3. Using the version of the code causes an exception.
What are the relevant issues?
#2511