Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional ACAHs: X-XSRF-TOKEN #2706

Closed
wants to merge 2 commits into from
Closed

Optional ACAHs: X-XSRF-TOKEN #2706

wants to merge 2 commits into from

Conversation

fennekit
Copy link

What's this PR do/fix?

#2578. Allow to exclude urls from the CSRF header

Are there unit tests? If not how should this be manually tested?

yes. For checking the configuration. No

Any background context you want to provide?

Like #2578 I ran into issues using KeyCloak with SpringFox. It is now possible to enable/disable CSRF support and/or filter out the header for certain domains.

What are the relevant issues?

CSRF headers are send for all requests.

@codecov
Copy link

codecov bot commented Sep 30, 2018

Codecov Report

Merging #2706 into master will decrease coverage by 0.05%.
The diff coverage is 68.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2706      +/-   ##
============================================
- Coverage     94.77%   94.72%   -0.06%     
- Complexity     3161     3163       +2     
============================================
  Files           354      354              
  Lines          8057     8071      +14     
  Branches        608      608              
============================================
+ Hits           7636     7645       +9     
- Misses          271      276       +5     
  Partials        150      150
Impacted Files Coverage Δ Complexity Δ
...umentation/swagger/web/UiConfigurationBuilder.java 92% <42.85%> (-8%) 16 <0> (ø)
...fox/documentation/swagger/web/UiConfiguration.java 90.66% <88.88%> (-0.38%) 24 <3> (+2)

@dilipkrish dilipkrish added the PR label Nov 9, 2018
@dilipkrish dilipkrish added this to the 3.0 milestone Nov 9, 2018
@dilipkrish
Copy link
Member

Thanks for your PR! I'll review and pull in this PR shortly.

@dilipkrish dilipkrish removed this from the 3.0 milestone Jul 14, 2020
@fennekit fennekit closed this by deleting the head repository Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants