Spring pageable support #2943
Spring pageable support #2943
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2943 +/- ##
=============================================
+ Coverage 70.13% 92.99% +22.86%
- Complexity 191 3469 +3278
=============================================
Files 503 376 -127
Lines 14822 9242 -5580
Branches 1308 758 -550
=============================================
- Hits 10395 8595 -1800
+ Misses 3831 462 -3369
+ Partials 596 185 -411 |
Codecov Report
@@ Coverage Diff @@
## master #2943 +/- ##
============================================
+ Coverage 94.32% 94.35% +0.03%
- Complexity 3239 3246 +7
============================================
Files 364 365 +1
Lines 8381 8409 +28
Branches 619 619
============================================
+ Hits 7905 7934 +29
Misses 318 318
+ Partials 158 157 -1
|
Zomzog
force-pushed
the
2761
branch
2 times, most recently
from
94239aa
to
e8921bc
Compare
| @@ -16,8 +16,10 @@ dependencies { | |||
| compile project(':springfox-spi') | |||
| compile project(':springfox-schema').sourceSets.main.output | |||
| compile project(':springfox-spring-web') | |||
| compile project(':springfox-swagger-common') | |||
There was a problem hiding this comment.
Why do we need this dependency?
There was a problem hiding this comment.
It's for adding annotation but maybe I can remove them.
| compile "com.athaydes.rawhttp:rawhttp-core:2.0" | ||
| compileOnly "org.springframework.restdocs:spring-restdocs-mockmvc:2.0.3.RELEASE" | ||
| compileOnly "org.springframework.data:spring-data-rest-webmvc:$springDataRest" |
There was a problem hiding this comment.
Not sure to understand what you mean by "provided".
|
@dilipkrish I've rebased it, I will try to answer faster this time. |
|
@Zomzog @dilipkrish One issue I see here is that this code uses the word |
good point, I've fixed the name. |
What's this PR do/fix?
Add spring
Pageableconfiguration support for #2761Are there unit tests? If not how should this be manually tested?
The unit test is partial
Any background context you want to provide?
I've added a hack for adding description and example. I think it's useful but I can remove it.
What are the relevant issues?
WIthout this config, generated swagger contain invalid fields and generate noncompilable code with openapi-generator