2967: disable DocumentationPluginsBootstrapper if spring-integration-plugin is present #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egration plugin is present, not if spring-integration is present
Codecov Report
@@ Coverage Diff @@
## master #2995 +/- ##
=========================================
Coverage 94.32% 94.32%
Complexity 3239 3239
=========================================
Files 364 364
Lines 8381 8381
Branches 619 619
=========================================
Hits 7905 7905
Misses 318 318
Partials 158 158
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2995 +/- ##
=========================================
Coverage 94.32% 94.32%
Complexity 3239 3239
=========================================
Files 364 364
Lines 8381 8381
Branches 619 619
=========================================
Hits 7905 7905
Misses 318 318
Partials 158 158
|
Thanks for the PR @dschulten, it wasn't clear from the PR how disabling this defers the execution. Or is it just not needed in that case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do/fix?
Fixes #2967
Are there unit tests? If not how should this be manually tested?
Test with https://github.com/springfox/springfox-demos
Any background context you want to provide?
Not all users who have spring-integration on the classpath also use spring-integration-webflux or spring-integration-http. We now postpone bootstrapping only if the SpringIntegrationDocumentationPluginsBootstrapper is in fact on the classpath.
What are the relevant issues?
In order to access the request mappings of spring-integration, the documentation plugins bootstrapper must execute after the spring-integration RequestHandlerMapping beans have been initialized, which happens later than with the plain RequestHandlerMapping beans.