Ignore _pytest.runner by default #288
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 8, 2019 07:59
This will fix pytest duration calculation. Fixes spulec#286
So that the change doesn't leak across tests
goodspark
commented
Feb 8, 2019
| api.call_stack_inspection_limit = ori_val | ||
|
|
||
|
|
||
| @pytest.mark.usefixtures('change_stack_limit') | ||
| def test_should_use_real_time(): |
There was a problem hiding this comment.
test_should_use_real_time fails. But if I comment out the lines that change call_stack_inspection_limit, they pass.
As a sanity check, I undid my change, left the call_stack_inspection_limit lines commented out, and the tests still passed. So I'm not sure what this is doing, other than increasing coverage. Perhaps another test should be written for that instead.
I think the other tests failed (from the run from the first commit) because the limit was 'leaking' across the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix pytest duration calculation. Fixes #286