Correct ticking behavior with time.time_ns()
#473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when `freeze_time(..., tick=True)` was used in conjunction with functions that called out to `time.time_ns()`, identical values were being returned. This was caused by the existing version of `fake_time_ns` rounding off the last nine digits of the returned integer value -- ensuring that each tick would be erased. This commit only casts to `int` _after_ the value has been shifted by `1e9`, rather than before _and_ after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when
freeze_time(..., tick=True)was used in conjunction with functions that called out totime.time_ns(), identical values were being returned. This was caused by the existing version offake_time_nsrounding off the last nine digits of the returned integer value -- ensuring that each tick would be erased.This commit only casts to
intafter the value has been shifted by1e9, rather than before and after.