Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds return value to tick() #542

Merged
merged 5 commits into from Apr 22, 2024
Merged

Adds return value to tick() #542

merged 5 commits into from Apr 22, 2024

Conversation

kingbuzzman
Copy link
Contributor

Closes #541

kingbuzzman
kingbuzzman commented Apr 16, 2024
View reviewed changes
tests/test_datetimes.py
assert frozen_datetime() == initial_datetime


def test_manual_increment_seconds():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that test_manual_increment_seconds and test_manual_increment were doing the same exact thing. So i deleted one of them.

@kingbuzzman
Copy link
Contributor Author

@bblommers when you get a chance, can you please approve me to run tests please. Thanks. Also some feedback would be helpful. Thanks again!

bblommers
bblommers approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense @kingbuzzman. Thank you for the PR!

@bblommers bblommers merged commit dfd5d9e into spulec:master Apr 22, 2024
10 checks passed
@kingbuzzman kingbuzzman deleted the patch-1 branch April 23, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bblommers bblommers bblommers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a return value to tick()
2 participants
@kingbuzzman @bblommers