PR: Fix issue where Spyder's inline graphics preferences were not applied #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrclary
changed the title
mrclary
force-pushed
the
issue-22304
branch
3 times, most recently
from
ee46d3c
to
870f22d
Compare
ccordoba12
reviewed
May 28, 2024
There was a problem hiding this comment.
@mrclary, sorry to say it but I think your current approach is not feasible (see below).
ccordoba12
changed the title
mrclary
force-pushed
the
issue-22304
branch
3 times, most recently
from
89dc88b
to
ccfb4a9
Compare
ccordoba12
reviewed
May 30, 2024
…kend if necessary. Do not directly set rcParams or re-apply inline backend since doing either while in inline mode will prevent restoring rcParams when toggling to interactive mode. Rather, toggle the backend to interactive and back to inline. Note that when adding InlineBackend to kernel.config, it must be a Config object.
…ne method _set_inline_config_option.
… there were any rc changes. Rather than condition on pylab autoload in the configuration, condition on it being true.
This prevents user's matplotlib rc parameters from being clobbered when Spyder's "Activate support" is disabled. This makes sense because when disabled, a user should expect that Spyder does not interfere in any way.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Apply rcParams explicitly while in inline mode. Always reset rcParams to file defaults before applying backend. This will ensure correct rcParams in interactive backends if rcParams are explicitly set in inline mode. When changing to inline mode, InlineBackend settings will be applied to rcParams.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
ccordoba12
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where:
rcParamsare over-written by Spyder's inline preferences even with the preference set for an interactive backend.For more detail, see spyder-ide/spyder#22034.