Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update py2app to 0.28 (Mac app) #17612

Merged
merged 9 commits into from
Apr 11, 2022
Merged

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Apr 4, 2022

Description of Changes

Update py2app to version 0.28.
This includes a new recipe for black, updated recipe for pyqt, and fixes for egg handling.
Some additions to the setup call brings the build into compliance with setuptools>60.10.0.

Issue(s) Resolved

Fixes #17609
Fixes #17551

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @mrclary

@mrclary mrclary self-assigned this Apr 4, 2022
@mrclary mrclary marked this pull request as draft April 4, 2022 21:11
@pep8speaks
Copy link

pep8speaks commented Apr 4, 2022

Hello @mrclary! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-04-11 15:48:27 UTC

@ccordoba12
Copy link
Member

@mrclary, our Mac app is failing to be built due to the release of Py2app 0.28. So, is there something else you need to finish here? Or can we merge it to fix our tests?

@mrclary mrclary marked this pull request as ready for review April 11, 2022 18:04
@mrclary mrclary requested a review from ccordoba12 April 11, 2022 18:05
@mrclary
Copy link
Contributor Author

mrclary commented Apr 11, 2022

I was waiting to ensure that these CI tests passed. Should be good to go now.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mrclary for your prompt help with this!

@ccordoba12 ccordoba12 merged commit 9f292bc into spyder-ide:5.x Apr 11, 2022
ccordoba12 added a commit that referenced this pull request Apr 11, 2022
@mrclary mrclary deleted the update-py2app branch April 12, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants