Add array pool and increase max stackalloc #34
Conversation
| Span<char> alphabetTemp = _alphabet.Length * sizeof(char) > MaxStackallocSize // NOTE: We multiply the number of characters by the size of a `char` to get the actual amount of memory that would be allocated. | ||
| ? new char[_alphabet.Length] | ||
| ? (pooledArray = ArrayPool<char>.Shared.Rent(_alphabet.Length)).AsSpan(_alphabet.Length) |
There was a problem hiding this comment.
The AsSpan is to ensure the correct length. As Rent most likely will give us an Array that is too big and avoids the implicit conversion.
|
Not sure the |
|
Oh in any case the single-byte character requirement in the constructor would prevent ever needing an array that is larger than 256 or even 512 😓 So not even sure why we need this check in this code 🤔 Because we are specifically looking for single-byte characters that are you unique, we can only fit up to 128 unique characters in a char array. |
Added support for use ArrayPool.Shared and increasing the max stackalloc size.
512 or even 1024 should be totally safe if it is the only stack allocation that happens in the Encode or Decode method body's stack frame.